On Thu, Jun 14, 2018 at 7:07 PM, Takashi Iwai tiwai@suse.de wrote:
On Thu, 14 Jun 2018 16:05:54 +0200, Jorge Sanjuan wrote:
Thanks for review!
Here is what's new in this V2:
- Split the patchset into a more sensible series.
This patchset adds support for the Insertion Control for BADD devices (subset of UAC3).
This control is only pressent in the HEADSET ADAPTER BADD profile. The USB interrupt pipe shall be present for this profile so the status pipe creation should also happen for BADD devices.
Also, the bi-directional type codes have been defined so they can be used as inferred values for the Input and Output terminals for this adapter profile.
Based on tag: next-20180612
Jorge Sanjuan (4): ALSA: usb-audio: Add bi-directional terminal types. ALSA: usb-audio: Change in connectors control creation interface ALSA: usb-audio: UAC3. Add insertion control for BADD. ALSA: usb-audio: Always create the interrupt pipe for the mixer
Thanks, this looks nicer, each of changes is smaller and clearer. Although it's a bit too late for the merge window, this is a change that is fairly safe for the existing UAC1/UAC2, I merged it now.
It's too late probably, but I just finished reviewing these patches and don't have any objections.
Thanks, Ruslan