On Mon, 24 Feb 2014 03:32:02 +0000 "Li.Xiubo@freescale.com" Li.Xiubo@freescale.com wrote:
@@ -20,7 +20,6 @@ struct simple_card_data { unsigned int daifmt; struct asoc_simple_dai cpu_dai; struct asoc_simple_dai codec_dai;
- struct snd_soc_dai_link snd_link;
};
static int __asoc_simple_card_dai_init(struct snd_soc_dai *dai, @@ -246,7 +245,9 @@ static int asoc_simple_card_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; int ret;
- priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
- priv = devm_kzalloc(dev,
sizeof(*priv) + sizeof(*dai_link),This is okey for me.
Well, how about splitting the *priv and *dai_link into two separated memory blocks? As we can get the dai-link pointer via priv->snd_card.dai_link in other places.
IMHO, then the code will be much more simplifier and readable.
It is just a simple optimization: less calls to memory allocation and less code (also, less TLB reload?). I will add more comments.