On 25-11-21, 09:25, Arnd Bergmann wrote:
On Thu, Nov 25, 2021 at 8:57 AM kernel test robot lkp@intel.com wrote:
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
drivers/dma/qcom/qcom_adm.c:712:18: warning: no previous prototype for function 'adm_dma_xlate' [-Wmissing-prototypes]
struct dma_chan *adm_dma_xlate(struct of_phandle_args *dma_spec, ^ drivers/dma/qcom/qcom_adm.c:712:1: note: declare 'static' if the function is not intended to be used outside of this translation unit struct dma_chan *adm_dma_xlate(struct of_phandle_args *dma_spec, ^ static 1 warning generated.
I noticed this mistake slipped into v2 as well, the function needs to be marked 'static'.
Vinod, let me know how you want me to address this. Should I just fold the fix (see below) and the final Acks into the patch and send an updated pull request, or do a complete v3 submission?
I can fold this while applying, the series lgtm, I will wait a day before applying...
Thanks
Arnd8<--- diff --git a/drivers/dma/qcom/qcom_adm.c b/drivers/dma/qcom/qcom_adm.c index bb338b303af6..65697bee4db0 100644 --- a/drivers/dma/qcom/qcom_adm.c +++ b/drivers/dma/qcom/qcom_adm.c @@ -709,8 +709,8 @@ static void adm_channel_init(struct adm_device *adev, struct adm_chan *achan,
- Returns pointer to appropriate dma channel on success or NULL on error.
*/ -struct dma_chan *adm_dma_xlate(struct of_phandle_args *dma_spec,
struct of_dma *ofdma)+static struct dma_chan *adm_dma_xlate(struct of_phandle_args *dma_spec,
struct of_dma *ofdma){ struct dma_device *dev = ofdma->of_dma_data; struct dma_chan *chan, *candidate = NULL;