Re: [PATCH v2 08/10] dt-bindings: sound: Add support for QMC audio

Hi Krzysztof,

On Sun, 8 Jan 2023 16:16:24 +0100 Krzysztof Kozlowski krzysztof.kozlowski@linaro.org wrote:

On 06/01/2023 17:37, Herve Codina wrote:

...

The QMC (QUICC mutichannel controller) is a controller present in some PowerQUICC SoC such as MPC885. The QMC audio is an ASoC component that uses the QMC controller to transfer the audio data.

Signed-off-by: Herve Codina herve.codina@bootlin.com

.../bindings/sound/fsl,qmc-audio.yaml | 110 ++++++++++++++++++ 1 file changed, 110 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml

diff --git a/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml b/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml new file mode 100644 index 000000000000..b3774be36c19 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml @@ -0,0 +1,110 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/fsl,qmc-audio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: QMC audio

+maintainers:

• • Herve Codina herve.codina@bootlin.com

+description: |

• The QMC audio is an ASoC component which uses QMC (QUICC Multichannel
• Controller) channels to transfer the audio data.
• It provides as many DAI as the number of QMC channel used.

+properties:

• compatible:
• items:

Drop items.

Will be dropped.

...

•  - const: fsl,qmc-audio
  

• '#address-cells':
• const: 1
• '#size-cells':
• const: 0
• '#sound-dai-cells':
• const: 1

+patternProperties:

• "^dai@([0-9]|[1-5][0-9]|6[0-3])$":
• description:

•  A DAI managed by this controller
  

• type: object
• properties:

•  reg:
  

•    minimum: 0
  

•    maximum: 63
  

•    description:
  

•      The DAI number
  

•  qmc-chan:  
  

Missing vendor prefix.

Will be changed to 'fsl,qmc-chan'

...

•    $ref: /schemas/types.yaml#/definitions/phandle-array  
  

Why this is not a phandle?

I have try '$ref: /schemas/types.yaml#/definitions/phandle'

I have an error from make dt_binding_check: dai@16:fsl,qmc-chan:0: [4294967295, 16] is too long

I need a phandle with an argument ie <&qmc 16>. Is there an alternative to phandle-array to handle this case ?

...

•    description: phandle to the QMC channel> +        maxItems: 1
  

• required:

•  - reg
  

•  - qmc-chan
  

+required:

• • compatible
• • '#address-cells'
• • '#size-cells'
• • '#sound-dai-cells'

+additionalProperties: false

+examples:

• • |
• qmc_audio: qmc_audio {

Same problem as in previous patch.

Changed to 'audio-controller'.

...

•    compatible = "fsl,qmc-audio";
  

•    #address-cells = <1>;
  

•    #size-cells = <0>;
  

•    #sound-dai-cells = <1>;
  

•    dai@16 {
  

•        reg = <16>;
  

•        qmc-chan = <&scc_qmc 16>;
  

•    };
  

•    dai@17 {
  

•        reg = <17>;
  

•        qmc-chan = <&scc_qmc 17>;
  

•    };
  

• };

Best regards, Krzysztof

Thanks for the review.

Best regards, Hervé