19 Dec
2013
19 Dec
'13
3:16 p.m.
On Wed, Dec 18, 2013 at 12:57:41PM +0100, Markus Pargmann wrote:
- /*
* imx51 and later SoCs have a slightly different IP that allows the
* SSI configuration while the SSI unit is running.
*
* More important, it is necessary on those SoCs to configure the
* sperate TX/RX DMA bits just before starting the stream
* (fsl_ssi_trigger). The SDMA unit has to be configured before fsl_ssi
* sends any DMA requests to the SDMA unit, otherwise it is not defined
* how the SDMA unit handles the DMA request.
*
* SDMA units are present on devices starting at imx35 but the imx35
* reference manual states that the DMA bits should not be changed
* while the SSI unit is running (SSIEN). So we support the necessary
* online configuration of fsl-ssi starting at imx51.
*/
- if (hw_type != FSL_SSI_MX51)
ssi_private->offline_config = true;
This is really confusing. I'd expect a switch statement here enumerating the pre-i.MX51 hardware types otherwise if there's a new variant added it'll do the wrong thing - the comment sounds like the opposite of the test.