-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Saturday, November 5, 2016 1:22 AM To: mengdong.lin@linux.intel.com Cc: alsa-devel@alsa-project.org; tiwai@suse.de; liam.r.girdwood@linux.intel.com; Shah, Hardik T <hardik.t.shah@intel.com>; Singh, Guneshwor O <guneshwor.o.singh@intel.com>; Koul, Vinod <vinod.koul@intel.com>; Ughreja, Rakesh A <rakesh.a.ughreja@intel.com>; Lin, Mengdong <mengdong.lin@intel.com> Subject: Re: [PATCH v7 07/11] ASoC: topology: Add support to configure existing physical DAI links
On Thu, Nov 03, 2016 at 01:04:27AM +0800, mengdong.lin@linux.intel.com wrote:
+ name = strlen(cfg->name) ? cfg->name : NULL; + stream_name = strlen(cfg->stream_name) ? cfg->stream_name : NULL;
Please replace these with normal if statements. Also, are we sure that we've sufficiently audited the input paths to ensure that the strings are always terminated?
Okay. I submitted patch to fix this - ASoC: topology: Check name strings of physical DAI links. This another minor ABI update, just a name change of a field and backward compatible. Thanks again for your review! Mengdong