On Tue, Jun 03, 2008 at 04:49:38PM +0200, Takashi Iwai wrote:
Yeah, it looks horrible at a first glance, but it's a known workaround for reverse selections...
Indeed - that was the main other solution I'd looked at. It seemed like too much splatter in the configuration for the drivers but it's about as good as it looks like it'll get if simply depending on input isn't going to be OK.
Looking at all this I'm thinking we may as well leave the jack stuff as a module - it'd at least make the dependency stuff at runtime slightly easier and if we're going to put in the effort to support all these mixes of SND and INPUT it's probably as well to remove the runtime dependency between ALSA and input if jacks aren't actually in use too.
Also, sound/jack.h should provide empty inline functions for the case CONFIG_SND_JACK=n. Then you'll be able to reduce ifdefs in the driver codes.
Yeah, probably. Though from that point of view it might be as well to cut out the SND_JACK middleman...