Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls

• /* Check if MCLK provided */
• rt5659->mclk = devm_clk_get(&i2c->dev, "mclk");
• if (IS_ERR(rt5659->mclk)) {

• if (PTR_ERR(rt5659->mclk) == -EPROBE_DEFER)
  

• 	return -EPROBE_DEFER;
  

The correct thing to do here is to check if != -ENOENT and then return the error code. Otherwise you silently ignore errors if a clock was specified, but there was an error requesting it.