Hi Uwe,
On Thu, Nov 26, 2020 at 6:03 PM Uwe Kleine-König u.kleine-koenig@pengutronix.de wrote:
The driver core ignores the return value of struct device_driver::remove because there is only little that can be done. For the shutdown callback it's ps3_system_bus_shutdown() which ignores the return value.
To simplify the quest to make struct device_driver::remove return void, let struct ps3_system_bus_driver::remove return void, too. All users already unconditionally return 0, this commit makes it obvious that returning an error code is a bad idea and ensures future users behave accordingly.
Signed-off-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven geert@linux-m68k.org
Note that the same can be done for ps3_vuart_port_driver.remove().
Gr{oetje,eeting}s,
Geert