On Tue, 2010-10-12 at 18:20 -0700, Peter Hsiang wrote:
This patch adds the MAX98088 CODEC driver.
Just trivial comments:
+static struct {
int readable;int writable;int vol;+} max98088_access[M98088_REG_CNT] = {
bool instead?
static struct { bool readable; bool writable, bool vol; } etc...
readable isn't used anywhere, writeable is used as bool vol isn't a good name as it's easy to confuse with volume. Maybe volatile_register?
+static int max98088_volatile_register(unsigned int reg) +{
return max98088_access[reg].vol;+}
No error checking if reg isn't limited to the array size.
+static const char *max98088_exmode_texts[] = {
[]
+static const char *max98088_ex_thresh[] = { /* volts PP */
[]
+static const struct soc_enum max98088_ex_thresh_enum[] = {
[]
+static const char *max98088_fltr_mode[] = {"Voice", "Music" };
[]
+static const char *max98088_extmic_text[] = { "None", "MIC1", "MIC2" };
[]
+static const char *max98088_dai1_fltr[] = {
static const char * const