On Mon, Sep 09, 2013 at 12:27, Mark Brown wrote:
Bringing this back to DA9055 though, the current method of initialisation, for PMIC and Codec, isn't complicated or confusing nor does it require a lot of effort. As well as this the implementation is logically sound. It should remain that way in my opinion. The only thing that should be updated is the I2C Id of the Codec to make it more meaningful, and preferably sooner rather than later so the issue can be finally put to bed.
Well, the obvious approach would seem to be to just do the registration of the CODEC I2C device from the MFD...
Had we felt that was the obvious approach then we'd have taken it, as it's much easier to 'fall in line'. However I believe the approach that we adopted was the obvious and correct one for our chip. It is just a shame that you don't see things the same way.
As it stands we have fully functional drivers integrated in the kernel, which are tested and proven. What remains as far as I'm concerned is a simple ID name change to make things cleaner, but you do not agree with this approach. Your suggestion is to move initialisation of the Codec to the MFD core of the PMIC driver which to me is unnecessary and limiting and is something I cannot agree with. Basically we're at a bit of an impasse here...