RE: [PATCH] ASoC: dt-bindings: dialog,da7219: convert to dtschema

-----Original Message----- From: Conor Dooley conor@kernel.org Sent: Saturday, May 20, 2023 00:30 To: David.Rau.opensource David.Rau.opensource@dm.renesas.com Cc: conor+dt@kernel.org; support.opensource@diasemi.com; lgirdwood@gmail.com; broonie@kernel.org; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; alsa-devel@alsa-project.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: dt-bindings: dialog,da7219: convert to dtschema

Hey David,

I think some wires got crossed here - what I meant was send 2 patches in a series, where one did the conversion and the other added the new property.

Hi Conor, Well noted and thanks for the kind explanation.

On Fri, May 19, 2023 at 09:23:21AM +0000, David Rau wrote:

Convert Dialog DA7219 bindings to DT schema format.

Signed-off-by: David Rau David.Rau.opensource@dm.renesas.com

• interrupt-names:
• oneOf:

•  - items:
  

•      - const: wakeup
  

•  - items:
  

•      - const: irq
  

• description:

•  Name associated with interrupt line.
  

•  Should be "wakeup" if interrupt is to be used to wake system,
  

•  otherwise "irq" should be used.
  

Hmm, that is not quite what I meant. I was thinking that you could add itemised descriptions for what the individual behaviours are. But on reflection, how about: interrupt-names: description: Should be "wakeup" if interrupt is to be used to wake the system, otherwise "irq" should be used. enum: - wakeup - irq

Understood.

• wakeup-source:
• type: boolean
• description:

•  Flag to indicate this device can wake system (suspend/resume).
  

• "#clock-cells":
• const: 1
• clock-output-names:
• minItems: 2
• maxItems: 2

I was thinking clock-output-names:

• items:
  • const: WCLK
  • const: BCLK

(assuming I didn't misunderstand the text binding!)

I suppose the clock-output-names is not a fixed property and could be defined by users. If no pre-defined here, the default setting will be configured by DA7219 driver.

• description:

•  Name given for DAI word clock and bit clock outputs.
  

• clocks:

maxItems: 1

I see.

• description:

•  phandle and clock specifier for codec MCLK.
  

• clock-names:
• const: mclk

•  dlg,jack-det-rate:
  

•    enum: ["32ms_64ms", "64ms_128ms", "128ms_256ms", 
  

• "256ms_512ms"]

The "s here are not needed btw, the other enums in the tree described like this (that use strings) avoid the "s.

Understood.

Thanks & apologies for the confusion, Conor.

Thanks for the kind feedback. Your suggestions really help a lot.

David

•    description:
  

•      Jack type detection latency (3/4 pole).
  

•    $ref: /schemas/types.yaml#/definitions/string