On Tue, Mar 15, 2016 at 11:00:53AM +0100, Takashi Iwai wrote:
On Tue, 15 Mar 2016 10:57:11 +0100, Vinod Koul wrote:
It is always better to use list_for_each_entry_safe() while doing cleanup. So use this instead of open coding this in list in snd_hdac_stream_free_all()
Signed-off-by: Jeeja KP jeeja.kp@intel.com Signed-off-by: Vinod Koul vinod.koul@intel.com
While this change is fine, we shouldn't trust blindly list_for_each_safe() as always safe. It assumes that the list removal is done only for the current item. But it's not always true. The loop in the current code is one of standard idiom in such a case.
Yes thanks for the warning :)
In anyway, take my ack when Mark applies it: Acked-by: Takashi Iwai tiwai@suse.de
Will add this for v2
--
~Vinod