Re: [alsa-devel] [PATCH v2 4/6] platform/x86: dell-laptop: import dell_micmute_led_set() from drivers/leds/dell-led.c

On Mon, Jan 16, 2017 at 3:22 PM, Michał Kępień kernel@kempniu.pl wrote:

To ensure all users of dell-smbios are in drivers/platform/x86, move the dell_micmute_led_set() method from drivers/leds/dell-led.c to drivers/platform/x86/dell-laptop.c.

Acked-by: Andy Shevchenko andy.shevchenko@gmail.com

Couple of nitpicks below.

--- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -30,6 +30,7 @@ #include <linux/i8042.h> #include <linux/debugfs.h>

#include <linux/seq_file.h> +#include <linux/dell-led.h>

Perhaps move this one line above

+#define GLOBAL_MIC_MUTE_ENABLE 0x364 +#define GLOBAL_MIC_MUTE_DISABLE 0x365

Same as Pali told.