Re: [alsa-devel] [PATCH v2 6+/6] platform/x86: dell-wmi-led: fix coding style issues

On Tue, Jan 17, 2017 at 9:17 AM, Michał Kępień kernel@kempniu.pl wrote:

Fix coding style issues in dell-wmi-led which checkpatch complains about to make sure the module gets a clean start in the x86 platform driver subsystem.

•   status = wmi_evaluate_method(DELL_LED_BIOS_GUID, 1, 1, &input, &output);
  
  

You may remove extra line.

    if (ACPI_FAILURE(status))
            return status;

•   if (0 == on_eighths)
  

•   if (on_eighths == 0)
            on_eighths = 1;
    if (on_eighths > 255)
            on_eighths = 255;
  

•   if (0 == off_eighths)
  

•   if (off_eighths == 0)
            off_eighths = 1;
    if (off_eighths > 255)
            off_eighths = 255;
  

Obviously they both are custom clamp{_t}().