Re: [PATCH 3/6] soundwire: qcom: set continue execution flag for ignored commands

On 01/02/2021 14:16, Vinod Koul wrote:

...

/* Configure number of retries of a read/write cmd */

• ctrl->reg_write(ctrl, SWRM_CMD_FIFO_CFG_ADDR, SWRM_RD_WR_CMD_RETRIES);

• if (ctrl->version_major == 1 && ctrl->version_minor >= 5 &&

•    ctrl->version_step >= 1) {
  

why not use raw version value?

     if (ctrl->raw > 0x10501 )

We can do that way as well, but Major Minor seems much clear to readers!

--srini