Re: [alsa-devel] [PATCH v2 16/16] ASoC: fsl-ssi: Use regmap

On Sat, Mar 15, 2014 at 06:43:36PM +0400, Alexander Shiyan wrote:

Суббота, 15 марта 2014, 13:44 +01:00 от Markus Pargmann mpa@pengutronix.de:

...

This patch replaces the ssi specific functions write_ssi, read_ssi and write_ssi_mask by standard regmap function calls.

...

...

diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c

...

...

+static const struct regmap_config fsl_ssi_regconfig = {

• .max_register = CCSR_SSI_SACCDIS,
• .reg_bits = 32,
• .val_bits = 32,
• .reg_stride = 4,

+#ifdef PPC

• .val_format_endian = REGMAP_ENDIAN_BIG,

+#endif +};

Why we cannot use REGMAP_ENDIAN_NATIVE here for all cases? Theoretically, we can use for i.MX SOCs with different endianness, so this will help us.

I can change and test it on i.MX, but I am not sure if it helps with the PPC situation as I don't have the hardware.

Regards,

Markus