Re: [PATCH -next 1/2] ASoC: tas5805m: Use devm_kmemdup to replace devm_kmalloc + memcpy

On Thu, Aug 10, 2023 at 07:47:37PM +0800, Li Zetao wrote:

• tas5805m->dsp_cfg_data = devm_kmalloc(dev, fw->size, GFP_KERNEL);

• tas5805m->dsp_cfg_data = devm_kmemdup(dev, fw->data, fw->size, GFP_KERNEL); if (!tas5805m->dsp_cfg_data) { release_firmware(fw); return -ENOMEM; }

• memcpy(tas5805m->dsp_cfg_data, fw->data, fw->size);

  release_firmware(fw);

You could probably now move the release_firmware call to be immediately after the devm_kmemdup attempt, and avoid having to call it from two different places.

Cheers, Daniel