26 Mar
2014
26 Mar
'14
3:32 a.m.
Hi Mark,
On 03/25/2014 07:27 PM, Mark Brown wrote:
On Tue, Mar 25, 2014 at 05:56:56PM +0800, Bo Shen wrote:
case SND_SOC_BIAS_ON:
if (IS_ENABLED(CONFIG_COMMON_CLK))if (wm8904->mclk)clk_prepare_enable(wm8904->mclk);No, this shouldn't depend on COMMON_CLK - there is no reason other clock API implementations shouldn't be able to use this. Providing a clock is something you can only do with COMMON_CLK but using one doesn't need that, generally using a clock is done unconditionally.
Actually in probe function, it does this check, if not CCF support, the wm8904->mclk is NULL. So, we can remove the CCF check here.
Thanks.
Best Regards, Bo Shen