Em Qua, 2007-09-05 às 15:34 -0700, Trent Piepho escreveu:
On Wed, 5 Sep 2007, Mauro Carvalho Chehab wrote:
Well, at first I misunderstood that we would share the PCI SSIDs together with enum items. Sharing only the enum items doesn't give much improvements. Sharing the card database may do, though.
So, I see Trent's point. The merge work wouldn't pay for the benifit by sharing only the enum id, not the card database.
I like the idea of sharing the database. This probably will mean that snd_bt87x would be dependent of bttv driver (or a bttv core driver). This have the advantage of helping also to fix some conflicts with dvb bttv driver.
I see how that could be an improvement. Now the bt87x driver has a whitelist of cards with sound and a blacklist of cards with DVB, while the bt878 DVB driver has the exact opposite lists. Except the two driver's lists aren't in sync of course.
The cx88 driver keeps the database in the core module. One drawback is that the database can't be __initdata, as it has to stick around after the core module is loaded so the other drivers that are loaded later can get at it. Of course, __initdata doesn't do any for most configurations and it's not that big of a drawback in practice.
Trent,
Could you work on such patches for 2.6.25? For 2.6.24, my suggestion is just to apply your already submitted one.
Takashi,
If you want, you may add my ack to the already-sent Trent's patch:
Reviewed-by: Mauro Carvalho Chehab mchehab@infradead.org
Cheers, Mauro.