25 Aug
2009
25 Aug
'09
11:54 a.m.
On Tuesday 25 August 2009 03:04:50 ext Candelaria Villareal, Jorge wrote:
Fix the write to PMBR1 register through I2C. Also, the constant which holds the value to write is now called TWL4030_GPIO6_PWM0_MUTE. This name is based on TRM to avoid confusion.
Signed-off-by: Jorge Eduardo Candelaria x0107209@ti.com
/* Set TWL4030 GPIO6 as EXTMUTE signal */
- twl4030_i2c_write_u8(TWL4030_MODULE_INTBR, EXTMUTE(0x02),
TWL4030_MODULE_INTBR);
- twl4030_i2c_read_u8(TWL4030_MODULE_INTBR, &pin_mux,
TWL4030_INTBR_PMBR1);- pin_mux &= ~TWL4030_GPIO6_PWM0_MUTE(0x3);
- pin_mux |= TWL4030_GPIO6_PWM0_MUTE(0x2);
I still think that using 0x03/0x02 instead of 0x3/0x2 looks better, but otherwise I see no problem with the patch.
Acked-by: Peter Ujfalusi peter.ujfalusi@nokia.com