Hello.
On Thu, 2009-10-01 at 08:39, pl bossart wrote:
+/** QOS
- Defines Audio Quality of Service
- */
+#define SND_QOS_HIFI 0 +#define SND_QOS_VOICE 1 +#define SND_QOS_SYSTEM 2
My $0.02 comment is that I don't know what QOS entails. I have no issue with all the other defines, but this one isn't quite clear. What exactly is supposed to happen if I set the QOS to voice? A lower SNR for voice? A lower latency for voice with a lower group delay? A lower oversampling ratio? An optimized routing for voice? All of the above?
Good point. The key is here that some systems offer lower quality audio which also has a lower power consumption. That would save power when being on a voice call but give you the best quality when listening to your music.
+#define SND_SCN_PHONECALL_HANDSET "phonecall handset" +#define SND_SCN_PHONECALL_HEADSET "phonecall headset" +#define SND_SCN_PHONECALL_BLUETOOTH "phonecall bluetooth" +#define SND_SCN_PHONECALL_IP "phonecall ip"
Same here, this is ambiguous, you can have an IP call over bluetooth. Which scenario would you use then? I guess if you want the scenarios to be used by apps in a portable way, a clearer definition of each scenario is probably needed?
I removed the defines here. We don't use them and should re-think and define them when we actually implement its users.
Thanks for your comments.
regards Stefan Schmidt