14 Apr
2023
14 Apr
'23
9:28 a.m.
On Fri, 14 Apr 2023 10:56:10 +0200, Oswald Buddenhagen wrote:
On Fri, Apr 14, 2023 at 10:26:26AM +0200, Takashi Iwai wrote:
BTW, I guess that one missing piece in your patch is the case where the drain is called at the moment of fully filled data. You added snd_pcm_playback_silence() at snd_pcm_do_drain_init(), but in this scenario, the call wouldn't do anything at this moment. But snd_pcm_playback_silence() won't be called afterwards because runtime->silence_size = 0. So this workaround won't take effect in that case, no?
the hunk in snd_pcm_update_hw_ptr0() should take care of that.
OK, I see. Thanks.
Takashi