On Tue, Nov 29, 2022 at 06:23:48PM +0530, Srinivasa Rao Mandadapu wrote:
Add __maybe_unused tag for system PM ops suspend and resume. This is required to fix allmodconfig compilation issue. Fixes: c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops")
This is incorrect, it should be '2d68148f8f85 ("ASoC: qcom: lpass-sc7180: Add system suspend/resume PM ops")'. I see you fixed that in v2, but this patch has already been applied ...
Srinivasa, it seems a similar patch is needed for commit c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops"). For that you could use SYSTEM_SLEEP_PM_OPS() instead of the maybe_unused tags as suggested by Nathan.
Mark, I appreciate you being responsive and picking patches quickly, it might help though to leave 'external' reviewers at least some time to provide their feedback :)