Re: [alsa-devel] [PATCH v2 3/9] ASoC: Intel: Skylake: add DSP platform widget event handlers

On Mon, Aug 17, 2015 at 10:56:38PM +0530, Vinod Koul wrote:

• if (list_empty(&s_pipe->w_list)) {

• ret = skl_tplg_get_pipe_widget(ctx->dev, w, s_pipe);
  

• if (ret < 0)
  

• 	return ret;
  

• }

I'm not entirely clear what this is supposed to do or if it does it correctly - I suspect it's trying to always create the pipe widget which might be a bit clearer if it just created the pipe widget. The fact that it's checking if a list is empty is a bit worrying, what if some but not all of the entries needed on that list are there? Is just getting a widget really sufficient initialisation?

• return skl_tplg_bind_unbind_pipe_modules(ctx, s_pipe, true);

+} +/*

• • A PGA represents a module in a pipeline. So in the Pre-PMU event of PGA

Blank line between functions and the next thing. I am getting fed up of seeing this.