On 23.07.2019 19:43, mirq-linux@rere.qmqm.pl wrote:
External E-Mail
On Tue, Jul 23, 2019 at 01:36:37PM +0000, Codrin.Ciubotariu@microchip.com wrote:
On 22.07.2019 21:27, Michał Mirosław wrote:
Allow SSC to be used on platforms described using audio-graph-card in Device Tree.
Signed-off-by: Michał Mirosław mirq-linux@rere.qmqm.pl
sound/soc/atmel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig index 06c1d5ce642c..9ef9d25bb517 100644 --- a/sound/soc/atmel/Kconfig +++ b/sound/soc/atmel/Kconfig @@ -25,7 +25,7 @@ config SND_ATMEL_SOC_DMA default y if SND_ATMEL_SOC_SSC_DMA=y || (SND_ATMEL_SOC_SSC_DMA=m && SND_ATMEL_SOC_SSC=y)
config SND_ATMEL_SOC_SSC_DMA
- tristate
- tristate "SoC PCM DAI support for AT91 SSC controller using DMA"
Could you please make something similar for SND_ATMEL_SOC_SSC_PDC? Also, I think that it should select ATMEL_SSC, to be able to use simple/graph-card with SSC.
Hmm. The Kconfig dependencies seems overly complicated, do you mind if I get rid of most of the entries in the process?
Best Regards, Michał Mirosław
'select' creates recursive dependencies with our machine drivers, but 'depends on' should work. The complication comes from the fact that PDC and DMA support for SSC can be both enabled at the same time, so I think we need all of them...
I am reviewing the rest of your patches, so bear with me please.
Best regards, Codrin