On Tue, Jun 22, 2021 at 09:42:10PM +0200, Takashi Iwai wrote:
On Tue, 22 Jun 2021 19:00:49 +0200, Geoffrey D. Bennett wrote:
From: Takashi Iwai tiwai@suse.de
The current way of the scarlett2 mixer code managing the usb_mixer_elem_info object is wrong in two ways: it passes its internal index to the head.id field, and the val_type field is uninitialized. This ended up with the wrong execution at the resume because a bogus unit id is passed wrongly. Also, in the later code extensions, we'll have more mixer elements, and passing the index will overflow the unit id size (of 256).
This patch corrects those issues. It introduces a new value type, USB_MIXER_BESPOKEN, which indicates a non-standard mixer element, and use this type for all scarlett2 mixer elements, as well as initializing the fixed unit id 0 for avoiding the overflow.
Tested-by: Geoffrey D. Bennett g@b4.vu Cc: stable@vger.kernel.org Signed-off-by: Takashi Iwai tiwai@suse.de
When submitting a patch, you have to your Signed-off-by line even if you are no author. Could you give it? Just reply with a proper SOB, then I'll fix manually.
Of course. You know how many times I've read Documentation/process/submitting-patches.rst ? Not enough for it to sink in, apparently :). Please append my SOB:
Signed-off-by: Geoffrey D. Bennett g@b4.vu
Thanks, Geoffrey.