On 5/18/17 7:49 AM, Paulo Sergio wrote:
Hi Pierre / List, how are you?
2017-05-15 10:10 GMT-03:00 Paulo Sergio pstglia@gmail.com:
Hi Pierre
Em 15/05/2017 09:44, "Pierre-Louis Bossart" pierre-louis.bossart@linux.intel.com escreveu:
On 5/13/17 12:11 AM, Paulo Sergio wrote:
- This device (Lenovo Yoga 2 1051F) is a bytcr device. However bios
status returned by iosf_mbi_read is 1000000001000000000000101000000 (bits 26:27 disabled). Had to force bytcr flag to be true in order to apply correct MCLK frequency (25Mhz) and use SSP0
Are you sure it's Baytrail-CR? where does this information come from? Those fields are tied to which PMIC is used and it would be extremely surprising to have a disconnect.
Sorry, I should have said that I assumed it is a Baytrail CR device because these features:
- it's a Z3745 soc
- acpi_ipc_irq_index used is 0 (0x1D is the 1st index listed on dsdt, just
like other bytcr devices)
- ssp0 is being used on this device, not ssp2
- it has a 25mhz clk
But these are not enough to state it is a bytcr right?
I tried to find some info/document on web that shows if Z3745 is a CR device or not, but I couldn't (comparing the launch price with other BYT released at the same date, like Z3735G/F, it is not - however, features match the criteria of bytcr like ssp0, acpi_ipc_irq_index, etc )
I double-checked the settings. If the bits 26:27 are set to 01 or 11 then for sure it's a BYT-CR device. If the bits are left as 00 then it's the reset value and it could be either of BYT-T or BYT-CR. In all the tests we did the detection worked, looks like this is the exception to the rule.
If the ACPI IRQ index is different then that's a pretty good hint as well. I am not familiar enough with those ACPI resources but if we could part the interrupt table maybe we would avoid the quirk by making the auto detection work better.
In any case, in order to use &bytcr_rvp_platform_data, I was thinking to add a quirk to this device. Do you think something like this would be accepted as a patch?
It'd be fine to have a quirk to set BYT-CR platform data, but I don't think it makes sense to make the tables more complicated than they already are. I'd just change the is_bytcr() function to take quirks into account at that level.
And since it's quite unknown how many configurations we might see like this I would also use a module parameter to override the autodetection (similar to what Takashi did in rt5640).
I'd also use this information in the machine driver to either use SSP2 or SSP0.
--- a/sound/soc/intel/atom/sst/sst_acpi.c +++ b/sound/soc/intel/atom/sst/sst_acpi.c @@ -404,6 +404,7 @@ static unsigned long cht_machine_id;
#define CHT_SURFACE_MACH 1 #define BYT_THINKPAD_10 2 +#define BYT_LENOVO_YOGA2 3
static int cht_surface_quirk_cb(const struct dmi_system_id *id) { @@ -404,6 +404,7 @@ static unsigned long cht_machine_id;
#define CHT_SURFACE_MACH 1 #define BYT_THINKPAD_10 2 +#define BYT_LENOVO_YOGA2 3
static int cht_surface_quirk_cb(const struct dmi_system_id *id) { { @@ -417,6 +418,12 @@ static int byt_thinkpad10_quirk_cb(const struct dmi_system_id *id) return 1; }
+static int byt_yoga2_quirk_cb(const struct dmi_system_id *id) +{
cht_machine_id = BYT_LENOVO_YOGA2;return 1;+}
static const struct dmi_system_id byt_table[] = { { @@ -426,6 +433,13 @@ static const struct dmi_system_id byt_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "20C3001VHH"), }, },
{.callback = byt_yoga2_quirk_cb,.matches = {DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),DMI_MATCH(DMI_CHASSIS_VERSION, "1051F"),},}, { }};
@@ -440,7 +454,6 @@ static const struct dmi_system_id cht_table[] = { { } };
static struct sst_acpi_mach cht_surface_mach = { "10EC5640", "cht-bsw-rt5645", "intel/fw_sst_22a8.bin", "cht-bsw", NULL,
&chv_platform_data }; @@ -449,6 +462,14 @@ static struct sst_acpi_mach byt_thinkpad_10 = { "10EC5640", "cht-bsw-rt5672", "intel/fw_sst_0f28.bin", "cht-bsw", NULL,
&byt_rvp_platform_data };
+static struct sst_acpi_mach byt_thinkpad_10 = {
"10EC5640", "cht-bsw-rt5672", "intel/fw_sst_0f28.bin", "cht-bsw", NULL,&byt_rvp_platform_data };
+static struct sst_acpi_mach byt_lenovo_yoga2 = {
{"WM510204", "bytcr_wm5102", "intel/fw_sst_0f28.bin","bytcr_wm5102", NULL,
&bytcr_rvp_platform_data };
static struct sst_acpi_mach *cht_quirk(void *arg) { struct sst_acpi_mach *mach = arg; @@ -469,6 +490,8 @@ static struct sst_acpi_mach *byt_quirk(void *arg)
if (cht_machine_id == BYT_THINKPAD_10) return &byt_thinkpad_10;
else if (cht_machine_id == BYT_LENOVO_YOGA2)return &byt_lenovo_yoga2; else return mach;
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel