On Tue, Jun 26, 2012 at 04:56:27PM +0200, Roberto Nibali wrote:
On Tue, Jun 26, 2012 at 3:21 PM, Mark Brown
This is essentially impossible to review as you've not said what's being fixed and have completely reformatted the table so the diff doesn't highlight the changes at all. What's wrong and what is the change fixing?
This is merely a match to the data sheet of various TLV320AIC310x codecs. I've planned on submitting almost the same patch a couple of months ago. The reformatting to my avail adds to readability, no values are changed. Only a couple of 0x00 are added for the missing
This is irrelevant, you shouldn't be putting several unrelated changes into a single patch. It's bad for review and it's bad for reading the history Mixing minor style changes with bug fixes is especially bad, whatever actual changes you've made are essentially invisible in all the reformating.
To be perfectly honest I personally find your new version less readable, having more numbers per line means more counting is needed to figure out which register is which.
You've still also not clearly described what the actual changes are...