Re: [alsa-devel] [PATCH V1 09/13] Main rewite of the mpc5200 audio DMA code

On Thu, May 14, 2009 at 6:51 AM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:

On Wed, May 13, 2009 at 09:59:18PM -0400, Jon Smirl wrote:

...

-static const struct snd_pcm_hardware psc_dma_pcm_hardware = { +static const struct snd_pcm_hardware psc_dma_hardware = {       .info = SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID |               SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER |               SNDRV_PCM_INFO_BATCH,

• .formats = SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_BE |
• SNDRV_PCM_FMTBIT_S24_BE | SNDRV_PCM_FMTBIT_S32_BE,

• .formats = SNDRV_PCM_FMTBIT_S32_BE,

This seems like a major and very surprising reduction in functionality. Why is this required?

I think I did this backwards. The AC97 DAI should be SNDRV_PCM_FMTBIT_S32_BE only and the DMA engine allow all four.