On Wed, 12 Jun 2019 16:46:24 +0200, Pierre-Louis Bossart wrote:
[Cc: Takashi]
On 6/12/19 4:44 AM, Kai Vehmanen wrote:
Hi all, this series addresses issues with ordering of HDA codec and controller suspends in the runtime PM flows. The implemented logic for SOF is similar to what has been used by the Intel AZX HDA driver.
To implement this, first a fix is needed to hdac_hdmic ASoC codec driver. SOF framework also needs to be extended to allow SOF devices to implement a runtime_idle callback. Third, concrete implementation is in a separate patch for APL/CNL Intel hardware, for which strict ordering of codec-controller power down sequence needs to be maintained.
Looks good to me Reviewed-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
but of course we'd want feedback from Takashi and other folks more familiar with the HDaudio history. There will be additional patches in the coming days where we are catching up with issues that were fixed in the legacy driver but either missed or not known to the SOF developers.
All look good. I already replied to the first one, but feel free to take my ack for the rest, too:
Reviewed-by: Takashi Iwai tiwai@suse.de
thanks,
Takashi