On Wed, Feb 22, 2012 at 06:34:49PM +0100, Takashi Iwai wrote:
First of all, we don't agree yet which naming rule to be applied. Since your patch assumes the case B, i.e. constant names corresponding only to the key type (HEADPHONE, etc), it's incompatible with the current implementation in HD-audio.
As I've *repeatedly* said the idea was to prefix the name once we'd got stuff merged into the same file (which means ripping out the HDA specific code) but if we're going to have to completely rework the ABI before you'll consider trying to fix things up in kernel then there's no point bothering.
In other words, if I merge your patch now, the only solution for HD-audio side for the time being is to disable CONFIG_SND_HDA_INPUT_JACK. That's why I hesitate to merge it now.
Well, that whole config option just shouldn't be there in the first place but that's another story...
And, it's why I prefer defining the naming rule at first, thus refining the implementation not to conflict with the existing one.
It seems like it's a bit late to worry about the naming scheme to that extent given that the existing ABI has already managed to get into one kernel release and looks like it's also going to get into 3.4 as well.
Right now the only tractable fix I can see is to implement something approximating the HDA ABI in ASoC but that just makes things even worse from a maintability point of view.