2 Jul
2012
2 Jul
'12
2:27 p.m.
On Mon, Jul 02, 2012 at 01:46:42PM +0200, Benoît Thébaudeau wrote:
This patch:
- adds a choice in snd_soc_dapm_get_volsw_mut() for stereo between 1 and 2 registers, like in snd_soc_get_volsw().
- fixes the missing stereo in other parts of dapm.
- removes the unused saved_value from struct snd_soc_dapm_widget.
There's a couple of high level problems here.
One is that you've got multiple different things in a single commit which isn't great practice for review, especially with such a vauge changelog.
The other is that while you say that this "fixes the missing stereo in other parts of dapm" I can't see any sign of any changes to (for example) the path setup code which would seem to be essential for supporting more than one channel in controls.