Re: [alsa-devel] [PATCH v5-resend 2/7] ASoC: sirf: Add SiRF audio port driver is used by SiRF internal audio codec

2014-03-06 17:20 GMT+08:00 Mark Brown broonie@kernel.org:

On Wed, Mar 05, 2014 at 04:34:35PM +0800, RongJun Ying wrote:

Applied, but...

...

• base = devm_ioremap(&pdev->dev, mem_res->start,
  

•                 resource_size(mem_res));
  

• if (base == NULL)
  

•         return -ENOMEM;
  

...use devm_ioremap_resource() instead, please send a followup patch fixing this.

The i2s, internal audio codec and audio port use same register physics address and size. So if one driver use the devm_ioremap_resource instead. The other driver will invoke devm_ioremap_resource failed.

Thanks