Re: [PATCH v2 3/4] soundwire: qcom: add support for mmio soundwire master devices

@@ -764,8 +786,11 @@ static int qcom_swrm_probe(struct platform_device *pdev) if (!ctrl->regmap) return -EINVAL; } else {

• /* Only WCD based SoundWire controller is supported */
  

• return -ENOTSUPP;
  

• ctrl->reg_read = qcom_swrm_cpu_reg_read;
  

• ctrl->reg_write = qcom_swrm_cpu_reg_write;
  

• ctrl->mmio = devm_platform_ioremap_resource(pdev, 0);
  

• if (IS_ERR(ctrl->mmio))
  

• 	return PTR_ERR(ctrl->mmio);
  

Shouldn't this be conditional on SLIMBUS being enabled, as done in your patch2?

}

ctrl->irq = of_irq_get(dev->of_node, 0);