Re: [PATCH -next] soundwire: intel: Remove ununsed function

On 09-09-20, 08:46, Pierre-Louis Bossart wrote:

On 9/9/20 8:15 AM, YueHaibing wrote:

...

If CONFIG_PM is not set, build warns:

drivers/soundwire/intel.c:488:12: warning: 'intel_link_power_down' defined but not used [-Wunused-function]

Move this to #ifdef block.

Yes, thanks for the report, it's a valid issue, but maybe the fix is to add __maybe_unused more consistently and remove the CONFIG_PM dependency.

Vinod, what would you prefer?

__maybe_unused is the recommendation, it should be updated to use that

Thanks