Re: [PATCH 0/8] ASoC: Add common modules support for ACP hw block

On Thu, Sep 30, 2021 at 06:54:10PM +0530, Ajit Kumar Pandey wrote:

We need to support I2S audio on various different platforms SOC in near future. At present we are creating new folder under soc/amd/ for each platforms support with separate I2S and DMA device modules across each SOC. Actually AMD's audio coprocessor block commonly known as ACP hw IP

This seems basically fine - I do think you're likely to run into issues going forward if you get much more board/device variation but only one trivial issue with not using a GPL symbol export that really needs looking at now, otherwise it looks good for merging.