On Thu, Jan 26, 2023 at 7:09 AM Matthew Wilcox willy@infradead.org wrote:
On Thu, Jan 26, 2023 at 04:50:59PM +0200, Mike Rapoport wrote:
On Thu, Jan 26, 2023 at 11:17:09AM +0200, Mike Rapoport wrote:
On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote:
+/* Use when VMA is not part of the VMA tree and needs no locking */ +static inline void init_vm_flags(struct vm_area_struct *vma,
unsigned long flags)
I'd suggest to make it vm_flags_init() etc.
Thinking more about it, it will be even clearer to name these vma_flags_xyz()
Perhaps vma_VERB_flags()?
vma_init_flags() vma_reset_flags() vma_set_flags() vma_clear_flags() vma_mod_flags()
Due to excessive email bouncing I posted the v3 of this patchset using the original per-VMA patchset's distribution list. That might have dropped Mike from the list. Sorry about that Mike, I'll add you to my usual list of suspects :) The v3 is here: https://lore.kernel.org/all/20230125233554.153109-1-surenb@google.com/ and Andrew did suggest the same renames, so I'll be posting v4 with those changes later today. Thanks for the feedback!