2 Jul
2014
2 Jul
'14
6:04 p.m.
On 07/02/2014 05:02 PM, Dan Murphy wrote:
On 07/02/2014 08:47 AM, Daniel Mack wrote:
Hi Dan,
On 07/02/2014 03:30 PM, Dan Murphy wrote:
- if (np) {
data->power_gpio = of_get_named_gpio(np, "enable-gpio", 0);- } else if (pdata) {
data->power_gpio = pdata->enable_gpio;- } else {
dev_err(dev, "Platform or dev tree data not set\n");return -ENODEV;- }
New code for GPIO handling should use the new gpiod interface. See include/linux/gpio/consumer.h, or the sta350 codec driver.
OK good catch. I will look into it.
Does the gpiod interface handle both pdata as well as dt?
Yes, please refer to Documentation/gpio/board.txt.
For that to work, you also need to rename the property to 'enable-gpios', even though there's only one.
I am looking for that restriction in the code. But don't see it. Will dig some more here.
Ah, dd34c37aa3 ("gpio: of: Allow -gpio suffix for property names") changed that, so both variants are now supported.
Daniel