This patch should be named : change the configuring way for sport, Because I found that the previous way is not reliable sometimes. Application like "tone" ,will call starup() twice before entering hw_params() to configure SPORT. in this case SPORT won't be configured at all.
Cliff
-----Original Message----- From: Mark Brown [mailto:broonie@sirena.org.uk] Sent: Friday, March 06, 2009 8:02 PM To: Bryan Wu Cc: Cliff Cai; alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH 1/5] ASoC: Blackfin: fix bug
- kernel willcrash when record and play in bf527-ezkit
On Fri, Mar 06, 2009 at 03:53:26PM +0800, Bryan Wu wrote:
From: Cliff Cai cliff.cai@analog.com
set constraint only if the value is not 0, change the
configuring way
for sport
Hrm. As far as I can tell the actual effect of this patch is to not do any of the per-format configuration for the sport if the sport has been configured once already - as far as I can tell nothing ever resets your 'configured' variable and this is the only place that the data format is taken into account. Won't this mean that if a second data format is played the audio will be mishandled since the hardware will not have been configured for the new audio format?
If it's really not possible to reconfigure the hardware (I'm assuming that this is what the actual crash is?) I would expect to see code added which remembers the format that has been configured and then adds a constraint in the startup() function enforcing that.