Re: [alsa-devel] [PATCH 4/5] ASoC: wm8960: add support for big-endian audio samples

Mark Brown wrote:

...

...

• snd_pcm_format_t format = params_format(params); int i;

  /* bit size */

• switch (params_format(params)) {

• switch (format) {

...please don't introduce unrelated changes, especially ones you don't mention in the changelog.

Well, the introduction of variable 'format' is for the default case in the switch statement:

+ default: + dev_err(codec->dev, "unsupported format %i\n", format); + return -EINVAL;

I would not call this change "unrelated".