-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Friday, May 29, 2015 2:59 AM To: Fang, Yang A Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; dgreid@chromium.org; Nujella, Sathyanarayana; kevin.strasser@linux.intel.com; Sripathi, Srinivas; Iriawan, Denny; Jain, Praveen K; Koul, Vinod Subject: Re: [PATCH v2 1/3] ASoC: max98090: read micbias from device property
On Thu, May 28, 2015 at 11:00:46AM -0700, yang.a.fang@intel.com wrote:
- maxim,dmic-freq: Frequency at which to clock DMIC
+- maxim,micbias: Micbias voltage applies to the analog mic
This needs to be more specific about what the value is - it looks like it's the value to be written into a particular register?
Yes it is written into the register. I will put more information
- err = device_property_read_u32(codec->dev, "maxim,micbias",
&micbias);
- if (err || micbias < M98090_MBVSEL_2V2 || micbias >
M98090_MBVSEL_2V8)
micbias = M98090_MBVSEL_2V8;We should be logging an error if we read and out of range value here - it's expected that the value might be missing but if we manage to read something and it's invalid we should say so rather than silently ignore it.
Okay, will put log if out of range .