Hi Lars,
On Wed, Oct 16, 2013 at 10:55:03AM +0200, Lars-Peter Clausen wrote:
+void *snd_malloc_dev_iram(struct device *dev, size_t size, dma_addr_t *dma) +{
- struct gen_pool *pool = of_get_named_gen_pool(dev->of_node, "iram", 0);
dev will be the dma controller device not the audio controller device. This means the iram property needs to be specified on dma controller node and will be shared by all users of that controller. Is this the intention?
True.
Also I think you need to check whether of_node is NULL before passing it to of_get_named_gen_pool.
Oh, you're right.
- unsigned long vaddr;
- if (!pool)
return NULL;- vaddr = gen_pool_alloc(pool, size);
- if (!vaddr)
return NULL;- if (dma)
This check will always be true.
I'll drop it and below as well.
Thank you. Nicolin Chen
*dma = gen_pool_virt_to_phys(pool, vaddr);- return (void *)vaddr;
+}
+/**
- snd_free_dev_iram - free allocated specific memory from on-chip internal memory
- @dev: DMA device pointer
- @size: size in bytes of memory to free
- @ptr: cpu-view address returned from snd_malloc_dev_iram
- @dma: dma-view address returned from snd_malloc_dev_iram
- This function requires iram phandle provided via of_node
- */
+void snd_free_dev_iram(struct device *dev, size_t size, void *ptr, dma_addr_t dma) +{
- struct gen_pool *pool = of_get_named_gen_pool(dev->of_node, "iram", 0);
- if (!pool)
return;- gen_pool_free(pool, (unsigned long)ptr, size);
- ptr = NULL;
This ...
- if (dma)
dma = 0;... and this assignment are noops
+} +#endif /* CONFIG_OF */ #endif /* CONFIG_HAS_DMA */