On Mon, 2020-04-20 at 16:05 +0900, Kuninori Morimoto wrote:
Hi Mark
Current snd_soc_component_driver has compr_ops, but it is created for ALSA, not for ALSA SoC. This means it doesn't know the callback is for which component, thus, each callback needs to get component via lookup function.
It is not good design, and will not work in the future, because ASoC can have multipul same name component which current lookup function can't handle.
This v2 patch-set adds new snd_compress_ops and call callbacks with component. v1 is here
Link: https://lore.kernel.org/alsa-devel/87blnqpuqp.wl-kuninori.morimoto.gx@renesa...
Kuninori Morimoto (8): ASoC: soc-compress: add snd_compress_ops ASoC: codec: wm_adsp: use snd_compress_ops ASoC: uniphier: use snd_compress_ops ASoC: qcom: q6sp6: use snd_compress_ops ASoC: intel: atom: use snd_compress_ops ASoC: sof: use snd_compress_ops ASoC: sprd: use snd_compress_ops ASoC: soc-compress: remove snd_compr_ops
LGTM, Morimoto-san. Thanks!
Reviewed-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com