10 Oct
2022
10 Oct
'22
11:19 a.m.
On Sat, Oct 08, 2022 at 09:16:55PM +0300, Siarhei Volkau wrote:
The patch fixes:
- incorrectly represented dB values in alsamixer, et al.
- Line In path stays powered off during capturing or bypass to mixer.
The patch improves:
- Exposes all mixer inputs (both Mics, LineIn and DAC) with their gain controls.
- Exposes output stage (post mixer) gain control and makes it new Master playback gain, DAC gain was the previous master. However, no Master mute now.
Known issues:
- Bypass path enablement isn't applied immediately, for make things going bit clock needs to be triggered for a bit, e.g. by aplay dummy.wav It might be a hardware bug, since the bit clock isn't declared as required for codec operation.
As covered in submitting-patches.rst this should really be split up into multiple patches, with one change per patch. This is especially the case here since you have a mix of fixes and new features which should be applied differently.
- SOC_DOUBLE_R_TLV("Master Capture Volume",
- SOC_DOUBLE_TLV("Master Capture Volume",
JZ4725B_CODEC_REG_CGR10,REG_CGR10_GIL_OFFSET,REG_CGR10_GIR_OFFSET,0xf, 0, jz4725b_adc_tlv),- SOC_DOUBLE_R_TLV("Mixer Line In Bypass Playback Volume", JZ4725B_CODEC_REG_CGR3,
This doesn't appear to correspond to what your patch description said and will presumably cause problems for any existing configurations...