we need everything that was removed in your proposal :-)
- memset(bus, 0, sizeof(*bus));
- bus->dev = dev;
- bus->io_ops = &io_ops;
- INIT_LIST_HEAD(&bus->stream_list);
- bus->irq = -1;
- bus->ext_ops = ext_ops;
- /*
* There is only one HDA bus atm. keep the index as 0.* Need to fix when there are more than one HDA bus.*/- bus->idx = 0;
- spin_lock_init(&bus->reg_lock);
This is the smallest set of initialization needed when you don't need hdmi/hdaudio codec support.
I don't understand it... Why SOF core needs to initialize the content of HD-audio bus object even if you won't use it?
we do use it left and right, but we only use the 'controller/DMA' parts of that structure. we have zero use for CORB/RIRB and codec-specific stuff when I2S and DMIC are the only connections to 3rd party chips
IOW, what's the merit of having hda-bus.c with the copy of snd-hda-core code? As far as I see, both hda.c and hda-bus.c are linked into the same snd-sof-intel-hda-common module. And, the former has the direct calls of HD-audio core API (with CONFIG_SND_SOC_SOF_HDA); i.e. snd-sof-intel-hda-common already depends on snd-hda-core if CONFIG_SND_SOC_SOF_HDA is on, no matter how you code hda-bus.c.
I agree we could implement hda-bus in a cleaner way - but it's a very small file. A larger core repartitioning would take quite a bit of time, and in the mean time we already have to sort out all the deltas between legacy driver and hdac library.
Anyways, that's it for me this week, enjoy your vacation!