26 Jan
2011
26 Jan
'11
8:35 p.m.
On Wed, Jan 26, 2011 at 05:43:06PM +0100, Takashi Iwai wrote:
struct hdspm_version {
- uint8_t card_type; /* enum hdspm_io_type */
- char cardname[20];
- unsigned int serial; unsigned short firmware_rev;
- int addons;
};
#define SNDRV_HDSPM_IOCTL_GET_VERSION _IOR('H', 0x43, struct hdspm_version)
Changing the existing ioctl isn't so pretty. If any, I'd vote for changing the ioctl number.
I chose to change the ioctl number. Luckily, until now, there's no userspace tool calling this ioctl, but of course, you never know.
+static char channel_map_unity_ss[HDSPM_MAX_CHANNELS] = {
Please don't put static arrays in the public header files.
Dropped the static now.
Otherwise it looks OK. It's huge, and maybe there are something to be fixed. But We can fix things after merging.
ACK.
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.gitCould you rebase your patch to the git tree above?
Done. Hope it applies cleanly now.
Ciao
--
mail: adi@thur.de http://adi.thur.de PGP/GPG: key via keyserver
Don't try to be different. Just be good. To be good is different enough.
--Arthur Freed