Re: [alsa-devel] [FFADO-devel] [RFC][PATCH] ALSA: firewire-lib: support Linux tracing to dump a part of packet data

On 27.03.2016 14:18, Takashi Sakamoto wrote:

/* * This module supports 'Two-quadlet CIP header with SYT field'. * For convenience, also check FMT field is AM824 or not. @@ -523,7 +534,11 @@ static int handle_in_packet(struct amdtp_stream *s, dev_err(&s->unit->device, "Detect discontinuity of CIP: %02X %02X\n", s->data_block_counter, data_block_counter);

• return -EIO;
  

• if (!trace_in_packet_enabled())
  

• 	return -EIO;
  

• /* To identifying this situation. */
  

• trace_in_packet(0xffffffff, 0xffffffff, 999, 99);
  

  }

This looks wrong. Tracing should not change the path taken.

cheers, daniel