Re: [alsa-devel] [PATCH v2 13/16] ASoC: fsl_ssi: Clean up _fsl_ssi_set_dai_fmt()

On Sun, Jan 14, 2018 at 11:40:31PM +0100, Maciej S. Szmigiero wrote:

...

case SND_SOC_DAIFMT_I2S:

• regmap_update_bits(regs, REG_SSI_STCCR,
  

• 		   SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(2));
  

• regmap_update_bits(regs, REG_SSI_SRCCR,
  

• 		   SSI_SxCCR_DC_MASK, SSI_SxCCR_DC(2));
  

  switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) { case SND_SOC_DAIFMT_CBM_CFS: case SND_SOC_DAIFMT_CBS_CFS:

• 	if (IS_ERR(ssi->baudclk)) {
  

• 		dev_err(ssi->dev,
  

• 			"missing baudclk for master mode\n");
  

• 		return -EINVAL;
  

• 	}
  

The original code did this check only for fsl_ssi_is_i2s_master(ssi), that is, only for SND_SOC_DAIFMT_CBS_CFS while here you also do it for SND_SOC_DAIFMT_CBM_CFS.

You are right. This patch isn't supposed to change that. I mixed an intention from another patch. Will revise this part in the v3.

Thanks a lot