Re: [PATCH v3 22/28] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

Hi Herve,

thanks for your patch!

On Wed, Aug 9, 2023 at 3:28 PM Herve Codina herve.codina@bootlin.com wrote:

The Lantiq PEF2256 is a framer and line interface component designed to fulfill all required interfacing between an analog E1/T1/J1 line and the digital PCM system highway/H.100 bus.

Signed-off-by: Herve Codina herve.codina@bootlin.com

(...)

• patternProperties:

•  '-pins$':
  

•    type: object
  

•    $ref: /schemas/pinctrl/pincfg-node.yaml#
  

Shouldn't that be pinmux-node.yaml?

•    additionalProperties: false
  

•    properties:
  

•      pins:
  

•        enum: [ RPA, RPB, RPC, RPD, XPA, XPB, XPC, XPD ]
  

•      function:
  

•        enum: [ SYPR, RFM, RFMB, RSIGM, RSIG, DLR, FREEZE, RFSP, LOS,
  

•                SYPX, XFMS, XSIG, TCLK, XMFB, XSIGM, DLX, XCLK, XLT,
  

•                GPI, GPOH, GPOL ]
  

•    required:
  

•      - pins
  

•      - function
  

Because those are certainly defined in that file.

Yours, Linus Walleij